Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable running session.install outside a venv #580

Merged
merged 4 commits into from
Mar 1, 2022

Conversation

DiddiLeija
Copy link
Collaborator

@DiddiLeija DiddiLeija commented Feb 24, 2022

Toward #503 (comment) and #537 (comment). Closes #541.

This PR finishes the work of removing the option of running session.install outside a venv, which is possible because we already had a deprecation phase since 2022.1.7 (see #537).

Sorry if I delayed a lot for pushing this, I created the branch a while ago but had several conflicts, and had to restart all the work again 😞 1.

TODO:

Footnotes

  1. About the branch name, no-venv-no-install, I've been thinking about it for a long time. If you've heard or seen the common rule "No shirt, no shoes, no service", you will understand "No venv, no install" 😅

@DiddiLeija
Copy link
Collaborator Author

Of course, this will fail for now (the tests will break!) but I'll fix that soon.

@DiddiLeija
Copy link
Collaborator Author

Oh no, the linters also failed :/

Copy link
Collaborator Author

@DiddiLeija DiddiLeija left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, a few questions below. Also, other suggestions are accepted.

tests/test_sessions.py Show resolved Hide resolved
nox/sessions.py Show resolved Hide resolved
@DiddiLeija DiddiLeija marked this pull request as ready for review February 24, 2022 19:19
@DiddiLeija DiddiLeija changed the title [WIP] Disable running session.install outside a venv Disable running session.install outside a venv Feb 24, 2022
@DiddiLeija
Copy link
Collaborator Author

Ok, I think this PR is ready now. I just want to know your opinion about my questions above :)

Copy link
Collaborator

@cjolowicz cjolowicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

nox/sessions.py Show resolved Hide resolved
tests/test_sessions.py Show resolved Hide resolved
@DiddiLeija
Copy link
Collaborator Author

Merging then. Thanks @cjolowicz for adding your review!

@DiddiLeija DiddiLeija merged commit 2093e74 into wntrblm:main Mar 1, 2022
@DiddiLeija DiddiLeija deleted the no-venv-no-install branch March 1, 2022 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Prevent use of session.install in sessions without a virtual environment
2 participants